RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v4]

Richard Reingruber rrich at openjdk.java.net
Wed Oct 13 09:34:02 UTC 2021


On Tue, 12 Oct 2021 21:06:00 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve @summary section of test.
>
> test/jdk/com/sun/jdi/ResumeAfterThreadResumeCallTest.java line 81:
> 
>> 79:         System.out.println();
>> 80:         System.out.println("###(Target,"+ threadName +") " + m);
>> 81:         System.out.println();
> 
> I'm not sure why you have the two extra `println()` calls. Seems to just add unneeded blank lines in the log file.

I'll remove them.
I think I copied the method from another test where I used a lot of jit compiler tracing.

> test/jdk/com/sun/jdi/ResumeAfterThreadResumeCallTest.java line 222:
> 
>> 220:         System.out.println();
>> 221:         System.out.println("###(Debugger) " + m);
>> 222:         System.out.println();
> 
> Same here with the extra `printlin()` calls

I'll remove them.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5849


More information about the serviceability-dev mailing list