RFR: 8271356: Modify jdb to treat an empty command as a repeat of the previous command [v5]
Ioi Lam
iklam at openjdk.java.net
Tue Oct 19 21:19:09 UTC 2021
On Thu, 23 Sep 2021 15:24:47 GMT, Jakob Cornell <duke at openjdk.java.net> wrote:
>> This has been under discussion on and off for the past month or so on serviceability-dev, and I think a CSR request is required, so this may be a work in progress.
>>
>> Notes on the patch:
>>
>> - The `list` command previously marked a line in each listing with `=>`. In a bare `list` this is the next line up for execution. Previously when requesting a specific location (e.g. `list 5`) the requested line would be marked. With the patch applied, `list` will only ever mark the next line up for execution. This is consistent with the behavior of GDB and PDB (at least).
>> - `EOF` is printed when the repeat setting is on and a bare `list` command follows a listing containing the last source line. This feature is from PDB; it's a somewhat softer message than the one for an explicit `list` request that's out of range.
>> - I don't speak Chinese or Japanese, so I've omitted localizations for the new messages in those locales. However, I updated the help text in both to include the new commands, with the descriptions left empty for now.
>
> Jakob Cornell has updated the pull request incrementally with one additional commit since the last revision:
>
> 8271356: Invoke auto-advance on empty input after targeted list command
Hi Jacob, this is not your fault, but the "zz help text" in the Chinese and Japanese versions are in a single huge line. This makes it impossible to see what you have changed in the GitHub diffs, and impossible to tell whether you made any typos in the process.
I would recommend making a prerequisite PR first:
- Break the huge lines in those two files in the same way as TTYResources.java. Verify that TTYResources_ja.class, etc, are identical to the previous version. Integrate into openjdk.
- Revert the changes of those two files in the current PR
- Merge with the prerequisite PR
- Add the new lines into those two files
Thanks
- Ioi
-------------
Changes requested by iklam (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5290
More information about the serviceability-dev
mailing list