RFR: 8275185: Remove dead code and clean up jvmstat LocalVmManager

[Chris Plummer]

On Tue, 19 Oct 2021 21:41:41 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java line 80:
>> 
>>> 78:             "^hsperfdata_[0-9]+(_[1-2]+)?$";
>>> 79: 
>>> 80: 
>> 
>> I don't understand why you thought it best to remove these and instead use hard coded references to these partterns.
>
> I have two goals
> - these aren't used anywhere else, so it's better to at least move them from this file to LocalVmManager.java, where they are actually used. So you don't need to flip between two files.
> - the behavior is easier to understand if the string literals, comments, and the code that uses them are together.
> 
> Note that the original code has plenty of comment that are rather useless if you want to know how the files are searched.

ok

-------------

PR: https://git.openjdk.java.net/jdk/pull/5923