RFR: 8271356: Modify jdb to treat an empty command as a repeat of the previous command [v6]

[Jakob Cornell]

On Wed, 20 Oct 2021 03:06:00 GMT, Jakob Cornell <duke at openjdk.java.net> wrote:

>> This has been under discussion on and off for the past month or so on serviceability-dev, and I think a CSR request is required, so this may be a work in progress.
>> 
>> Notes on the patch:
>> 
>> - The `list` command previously marked a line in each listing with `=>`.  In a bare `list` this is the next line up for execution.  Previously when requesting a specific location (e.g. `list 5`) the requested line would be marked.  With the patch applied, `list` will only ever mark the next line up for execution.  This is consistent with the behavior of GDB and PDB (at least).
>> - `EOF` is printed when the repeat setting is on and a bare `list` command follows a listing containing the last source line.  This feature is from PDB; it's a somewhat softer message than the one for an explicit `list` request that's out of range.
>> - I don't speak Chinese or Japanese, so I've omitted localizations for the new messages in those locales.  However, I updated the help text in both to include the new commands, with the descriptions left empty for now.
>
> Jakob Cornell has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8271356: Revert non-transparent localization changes

Based on my local testing it appears the localization system falls back to the English values when entries are missing, so it appears the current behavior does already match what you've suggested.  However, I don't understand the mechanism that implements this fallback handling, so I'm not sure the behavior would be consistent across environments.  At least for now I'll add those entries back with the English translations copied, since that seems better.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5290