RFR: 8269685: Optimize HeapHprofBinWriter implementation [v5]

Lin Zang lzang at openjdk.java.net
Tue Sep 14 14:27:07 UTC 2021


On Mon, 13 Sep 2021 23:48:57 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Hi Serguei, 
>>     I update the PR to make the `calculateGlobalJNIHandlesDumpRecordSize()` method abstract. 
>>     For other empty ones that already there in original implementation, I will leave them as they are. do you think it is OK? 
>> 
>> BRs,
>> Lin
>
>> Hi Serguei,
>> I update the PR to make the `calculateGlobalJNIHandlesDumpRecordSize()` method abstract.
>> For other empty ones that already there in original implementation, I will leave them as they are. do you think it is OK?
>> 
>> BRs,
>> Lin
> 
> Hi Lin,
> Yes, I'm okay with that.
> Thanks,
> Serguei

Hi @sspitsyn, 
Thanks for your review and comments, I will fix them asap.
BRs,
Lin

-------------

PR: https://git.openjdk.java.net/jdk/pull/4666


More information about the serviceability-dev mailing list