RFR: 8273684: Unnecessary Stack usage

Chris Plummer cjplummer at openjdk.java.net
Tue Sep 14 17:55:08 UTC 2021


On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> Usage of thread-safe collection Stack is unnecessary. It's recommended to use ArrayDequeue if a thread-safe implementation is not needed.

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 988:

> 986:                 // Make sure the types are emitted in an order than can be read back in
> 987:                 HashSet<String> emitted = new HashSet<>();
> 988:                 ArrayDeque<Type> pending = new ArrayDeque<>();

Have you run the clhsdb vmstructsdump command to make sure the ordering hasn't changed?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5294


More information about the serviceability-dev mailing list