RFR: 8273916: Remove 'special' ranking [v2]

David Holmes dholmes at openjdk.java.net
Mon Sep 20 23:34:59 UTC 2021


On Mon, 20 Sep 2021 22:54:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change removes the special ranking and folds it into nosafepoint.  You have to look at commit #3 to see this actual part of the change that doesn't include JDK-8273915.
>> This passes tier1-6 also.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment about ThreadSMRDelete_lock

So there is more to this than just removing the "special" ranking - you've also changed some locks that are safepoint_never, that used to have ranks above what is now nosafepoint, so that they instead have ranks below nosafepoint - is that right? As long a all relative rankings of locks that can be taken together is maintained, then that is okay - but it is very hard to see that just by looking at the changes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5563


More information about the serviceability-dev mailing list