RFR: 8271356: Modify jdb to treat an empty command as a repeat of the previous command [v4]

Jakob Cornell github.com+5642931+jakobcornell at openjdk.java.net
Wed Sep 22 18:41:54 UTC 2021


On Fri, 3 Sep 2021 05:05:34 GMT, Jakob Cornell <github.com+5642931+jakobcornell at openjdk.org> wrote:

>> This has been under discussion on and off for the past month or so on serviceability-dev, and I think a CSR request is required, so this may be a work in progress.
>> 
>> Notes on the patch:
>> 
>> - The `list` command previously marked a line in each listing with `=>`.  In a bare `list` this is the next line up for execution.  Previously when requesting a specific location (e.g. `list 5`) the requested line would be marked.  With the patch applied, `list` will only ever mark the next line up for execution.  This is consistent with the behavior of GDB and PDB (at least).
>> - `EOF` is printed when the repeat setting is on and a bare `list` command follows a listing containing the last source line.  This feature is from PDB; it's a somewhat softer message than the one for an explicit `list` request that's out of range.
>> - I don't speak Chinese or Japanese, so I've omitted localizations for the new messages in those locales.  However, I updated the help text in both to include the new commands, with the descriptions left empty for now.
>
> Jakob Cornell has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8271356: Add jtreg tests for command repetition and list auto-advance

Thanks for following up on that Chris.  Are there any outstanding changes that need to be made to the PR then, or are we waiting for the CSR process?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5290


More information about the serviceability-dev mailing list