RFR: 8274168: Avoid String.compareTo == 0 to check String equality in java.management [v2]
Andrey Turbanov
github.com+741251+turbanoff at openjdk.java.net
Thu Sep 23 08:00:26 UTC 2021
On Thu, 23 Sep 2021 04:26:07 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> I look at it this way, the code should really (IMHO) have been written as:
>>
>> int res = sval1.compareTo(sval2);
>> switch(relOp) {
>> case Query.GT: return res > 0;
>> case ...
>> }
>>
>> and so the use of equals() instead would never have arisen. :)
>
> Yep, that works for me.
Ok. Done.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5640
More information about the serviceability-dev
mailing list