RFR: 8274196: Crashes in VM_HeapDumper::work after JDK-8252842 [v5]

[Chris Plummer]

On Mon, 27 Sep 2021 14:28:43 GMT, Lin Zang <lzang at openjdk.org> wrote:

>> The root cause for crash in ZGC is that the JNIHandles are processed before object iteration. And ZGC would update the JNIHandles at object iteration with read barrier. So the crash is cause by accessing the invalid address which can be dummy info after zgc, and hence crash.
>> 
>> The lock rank issue can be fixed because the related mutexes are acquired in safepoint. so the safepoint_check_required could be safepoint_check_always.
>> 
>> The Epsilon issue is caused by wrong _num_dumper_thread calculated when the gang==NULL.
>
> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove load barrier for JNI local roots

The dumper threads related fix looks fine. I don't know enough to verify the GC fix, but I think Per has that covered sufficiently. Likewise for the lock rank issue which Coleen has reviewed. Also, I tested your changes with our tier2 and tier3 CI runs, which is where the failures initially turned up, and they are passing now.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5681