RFR: 8285032: [LOOM] vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008/ fails with "eventSet.suspendPolicy() != policyExpected" [v2]

Chris Plummer cjplummer at openjdk.java.net
Wed Apr 27 17:58:47 UTC 2022


On Tue, 26 Apr 2022 23:20:19 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008.java line 421:
> 
>> 419:         try {
>> 420:             ThreadStartRequest tsr = eventRManager.createThreadStartRequest();
>> 421: //            tsr.addThreadFilter(mainThread);
> 
> I suppose the fix might be just to uncomment this line.
> Your solution is more complex, but should work too

I don't think that filter is correct. ThreadStartEvents are always delivered on the thread that is starting. Adding a thread filter for "main" is going to result in never finding a matching ThreadStartEvent since "main" has already started and it won't match any of the newly started threads.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8350


More information about the serviceability-dev mailing list