RFR: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage\: 68.31\: expected true, was false"

Kevin Walls kevinw at openjdk.org
Mon Aug 8 21:52:24 UTC 2022


On Mon, 8 Aug 2022 19:52:47 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The test should use the same locales in all processes, the default language should work fine.

I tried a few locales and could not reproduce the problem, I was expecting some kind of mismatch would trigger it, but not sure what to set where to cause this...

Something else I noticed while looking however: I looked at JstatGCUtilParser.java / verify(String... valueArray)
I see it checks values are of the right type: but after almost all checks, it does a "break",
so stops iterating values.
Only percentage checks permit checking to continue. 8-)
There are three "break" statements in verify(String... valueArray) which should be "continue".
We can handle that in a separate issue.

-------------

PR: https://git.openjdk.org/jdk/pull/9798


More information about the serviceability-dev mailing list