RFR: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage\: 68.31\: expected true, was false" [v2]

[Kevin Walls]

On Tue, 9 Aug 2022 02:35:14 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The test should use the same locales in all processes, the default language should work fine.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix

Thanks, great to fix the verifier now if we can.

I do think that never setting user.language is good.  Forcing jstat to run with user.language=en could be wrong, as there is a risk of mismatching the printing and the verification.

BUT I don't see why I can't reproduce the problem.. The report is on Windows, and I can sign in using a non-English language but can't make the test fail!...

But then it's not the parsing in NumberFormat that fails, it's the assert afterwards.

----------System.err:(19/1147)----------
java.lang.RuntimeException: Not a percentage: 68.31: expected true, was false

Annoyingly we print the literal String value "68.31" but not the double percentage that it parsed....

-------------

PR: https://git.openjdk.org/jdk/pull/9798