RFR: 8292267: Clean up synchronizer.hpp
David Holmes
dholmes at openjdk.org
Fri Aug 12 21:11:13 UTC 2022
On Fri, 12 Aug 2022 00:42:52 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> Fix two problems with synchronizer.hpp:
>
> - It's unnecessarily included in two popular headers: monitorChunk.hpp and frame_<cpu\>.hpp. The latter is most problematic because it includes synchronizer.hpp in the middle of a class declaration!
> - synchronizer.hpp includes linkedlist.hpp. This can be avoid by moving the definition of Synchronizer::PtrList into synchronizer.cpp.
>
> These headers are included much less after this PR (out of ~1000 hotspot .o files)
>
>
> linkedlist.hpp 857 -> 101
> synchronizer.hpp 848 -> 122
> resourceHash.hpp 850 -> 270
Looks fine.
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9849
More information about the serviceability-dev
mailing list