RFR: 8292250: Create test for co-located JDI MethodEntry, Step, and Breakpoint events [v5]
    Alex Menkov 
    amenkov at openjdk.org
       
    Thu Aug 25 21:46:54 UTC 2022
    
    
  
On Thu, 25 Aug 2022 19:14:21 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> We currently have no tests for co-located MethodEntry, Step, and Breakpoint events. We should make sure they are being properly co-located as described in the JDI spec, and also do special test cases for [JDK-8292217](https://bugs.openjdk.org/browse/JDK-8292217).
>> 
>> https://docs.oracle.com/en/java/javase/17/docs/api/jdk.jdi/com/sun/jdi/event/EventSet.html
>> 
>> And sorry in advance that the logic is a bit hard to follow in this test due to having multiple test cases, and dealing with the async nature of JDI testing. All I can say is that is used to be a lot worse before I did multiple passes to improve it.
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Undo last change to validate breakpoints. Fix bug with setting testFailed.
Still LGTM
-------------
Marked as reviewed by amenkov (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9840
    
    
More information about the serviceability-dev
mailing list