RFR: JDK-8292066 Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version [v2]

Leonid Mesnik lmesnik at openjdk.org
Mon Aug 29 23:40:12 UTC 2022


On Mon, 29 Aug 2022 23:25:11 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This task converts 2 shell tests to java version. 
>> test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh 
>> test/java/lang/management/RuntimeMXBean/TestInputArgument.sh
>
> Bill Huang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Added a blank line between fields and methods.
>  - Implemented review comments.

test/jdk/java/lang/management/OperatingSystemMXBean/GetSystemLoadAverage.java line 73:

> 71:                         String.format("Run %d: TestSystemLoadAvg", i));
> 72:                 if (!Platform.isWindows()) {
> 73:                     // On Linux or Solaris

Sorry, if missed the first time. It is Linux or Mac, or better something like *mix.

test/jdk/java/lang/management/OperatingSystemMXBean/GetSystemLoadAverage.java line 95:

> 93:                                 i));
> 94:                 if (i == MAX_RETRIES)
> 95:                 {

please move move brace to the prev line

-------------

PR: https://git.openjdk.org/jdk/pull/9848


More information about the serviceability-dev mailing list