RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v3]

[David Holmes]

On Mon, 29 Aug 2022 12:11:03 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/classfile/protectionDomainCache.cpp line 168:
>> 
>>> 166: }
>>> 167: 
>>> 168: void ProtectionDomainCacheTable::print_on(outputStream* st) {
>> 
>> It is a little disconcerting that `print_on` can no longer be a `const` function!
>
> It's static, so it can't.

Ah I see - I hadn't noticed it was now static.

>> src/hotspot/share/classfile/protectionDomainCache.cpp line 186:
>> 
>>> 184: 
>>> 185: // The object_no_keepalive() call peeks at the phantomly reachable oop without
>>> 186: // keeping it alive. This is okay to do in the VM thread state if it is not
>> 
>> You don't call `object_no_keepalive()` any more
>
> This one (not the one I removed), is called by dictionary.cpp - the pd_set is a linked list of ProtectionDomainEntry, where we don't keep the WeakHandle alive when looking at the value.

I don't understand your point. My point is that the comment no longer seems correct.

-------------

PR: https://git.openjdk.org/jdk/pull/10043