RFR: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations [v4]
Chris Plummer
cjplummer at openjdk.java.net
Wed Feb 2 19:01:03 UTC 2022
On Wed, 2 Feb 2022 18:45:33 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Are you still hitting the assert in fillInvokeRequest()? I'm not sure why it would ever not be NULL there. It's probably worth investigating some more. Otherwise you need to remove the assert, and possibly still have a leak.
>
>> Are you still hitting the assert in fillInvokeRequest()? I'm not sure why it would ever not be NULL there. It's probably worth investigating some more. Otherwise you need to remove the assert, and possibly still have a leak.
>
> No, the latest version seems good and passes tier1-3 and customer confirmed that it fixes the memory leak.
Ok. I think I prefer you to free the memory after calling `deleteGlobalArgumentRefs()` since `deleteGlobalArgumentRefs()` is really all about releasing JNI global refs, not freeing other allocated memory.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7306
More information about the serviceability-dev
mailing list