RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v5]

[Serguei Spitsyn]

On Wed, 2 Feb 2022 12:03:47 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Changes:
>> - ClassFileReconstituter is updated to restore "MethodParameters" attribute;
>> - handling of the attribute in VM_RedefineClasses is moved to be consistent with other code (like local variable table);
>> - copied ClassTransformer class (from test/jdk/com/sun/jdi/lib/jdb) to /test/lib as it's used by tests from hotspot and jdk (and also by test from Valhalla repo); Will file a follow up issues to updates tests and remove the class from test/jdk/com/sun/jdi/lib/jdb
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Split verification of presence and absence of the parameter names

The update looks good to me.
I've inlined just one minor comment about naming.
Thanks,
Serguei

test/jdk/java/lang/instrument/RetransformWithMethodParametersTest.java line 100:

> 98:     }
> 99: 
> 100:     private Parameter[] getTargetClassParameters() throws ClassNotFoundException {

Should this be named getTargetMethodParameters instead?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7180