RFR: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations [v5]

[Serguei Spitsyn]

On Wed, 2 Feb 2022 19:34:14 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> We observe a native memory leak when repeating JDI operations from Eclipse in a debuggee JVM. See bug report for details.
>> 
>> AFAICT, this happens because we override methodSignature of a possible pre-existing request object. I am not sure if there is a better place to deallocate the signature.
>> 
>> Also, I am not sure how to make an automated test for this. We (that is, the customer that reported the problem) verified that the memory leak disappears with the fix.
>> 
>> Testing:
>>  - [x] tier1
>>  - [x] tier2
>>  - [ ] tier3
>>  - [x] Customer confirming fix of memory leak
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move freeing of methodSignature after deleteGlobalArgumentRefs()

Hi Roman,
It looks good to me.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7306