RFR: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing

[Daniel D.Daugherty]

On Fri, 4 Feb 2022 11:18:39 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> The test expects ClassFileReconstituter restores exactly the same bytes as original classbytes.
> This can be wrong if the class has more than 1 method (due to method sorting in the VM).
> MethodParametersTarget class had only 1 method (method1), but didn't have constructors. This caused declaration of implicit default constructor, so the class actually had 2 methods.
> The fix converts the method to constructor to avoid default constructor declaration.

Thumbs up on the changes.

However, there's no details on how this fix was tested. Please clarify.
So far this test failure has been seen intermittently in Tier3.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7345