RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422

David Holmes dholmes at openjdk.java.net
Tue Feb 22 12:05:50 UTC 2022


On Mon, 21 Feb 2022 14:43:27 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using the newly introduced method `JavaThread::thread_from_jni_environment`.

I don't like unnecessary special-cases. I added the `ShouldNotReachHere()` due to flawed reasoning, so would like to remove it again and make the code look the way it would have if I had realized about AGCT at the time. Creating a new API just for AGCT to use is not necessary IMO.

Cheers.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7559


More information about the serviceability-dev mailing list