RFR: 8281614: serviceability/sa/ClhsdbFindPC.java fails with java.lang.RuntimeException: 'In code in NMethod for jdk/test/lib/apps/LingeredApp.steadyState' missing from stdout/stderr

[Daniel D.Daugherty]

On Tue, 22 Feb 2022 22:38:08 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java line 61:
>> 
>>> 59:  * @bug 8193124
>>> 60:  * @summary Test the clhsdb 'findpc' command w/o Xcomp on live process
>>> 61:  * @requires vm.hasSA
>> 
>> Summary says  w/o xcomp but no requires clause to reject Xcomp mode
>
> I think that is related to why xcomp-process and xcomp-core are not in agreement. Probably also a bug introduced when adding the two core tests (just like the DeoptimizeALot check was done wrong). As a reference, here's what it looked like before adding the two core tests:
> 
> 
>  * @requires vm.hasSA
>  * @requires vm.compiler1.enabled
>  * @requires vm.opt.DeoptimizeALot != true
>  * @run main/othervm/timeout=480 ClhsdbFindPC true
> 
>  * @requires vm.compMode != "Xcomp"
>  * @requires vm.hasSA
>  * @requires vm.compiler1.enabled
>  * @run main/othervm/timeout=480 ClhsdbFindPC false
> 
> The first test is running the debuggee with -Xcomp. The test itself can be run with or without -Xcomp. The second runs the debuggee without -Xcomp. In this case the test is not allowed to be run with -Xcomp, because it would be passed to the debuggee (although with some work the test could have stripped it). I believe Leonid added this restriction to avoid unnecessarily testing the debuggee in -Xcomp mode twice. To be it consistent it looks like I need to move the `@requires vm.compMode != "Xcomp"` from `id=xcomp-core` to `no-xcomp-process`. The other choice is to just remove this restriction. I wasn't a fan of it when it went in initially.

Personally, I'm not a fan of running the debugger/debuggee tests with the debugger in -Xcomp mode.
I don't think that represents a real world usage scenario. Exercising the debuggee in -Xcomp mode
is useful IMHO.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7542