RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v4]

Martin Doerr mdoerr at openjdk.java.net
Thu Feb 24 09:32:12 UTC 2022


On Wed, 23 Feb 2022 21:59:35 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using the newly introduced method `JavaThread::thread_from_jni_environment`.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove old code

LGTM.

src/hotspot/share/prims/forte.cpp line 565:

> 563: JNIEXPORT
> 564: void AsyncGetCallTrace(ASGCT_CallTrace *trace, jint depth, void* ucontext) {
> 565: 

Feel free to remove the extra newline.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7559


More information about the serviceability-dev mailing list