RFR: 8279194: Add Annotated Memory Viewer feature to SA's HSDB [v2]

Chris Plummer cjplummer at openjdk.java.net
Sun Jan 2 01:31:40 UTC 2022


On Fri, 24 Dec 2021 03:06:45 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - minor code cleanup
>>  - Update copyrights
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/MemoryPanel.java line 140:
> 
>> 138:               Address addr = bigIntToAddress(bigaddr);
>> 139: 
>> 140:               col1 = bigIntToHexString(bigaddr);
> 
> Nit: This can be simplified just a little bit by moving the lines 137-138 above line 134.
> So, it will be like this:
> 
>               BigInteger bigaddr = startVal.add(new BigInteger(Integer.toString((row * addressSize))));
>               Address addr = bigIntToAddress(bigaddr);
>               String col1 = bigIntToHexString(bigaddr);
>               String col2 = unmappedAddrString;
>               String col3 = "";

ok, I updated it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6923


More information about the serviceability-dev mailing list