RFR: 8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error

[Chris Plummer]

On Fri, 31 Dec 2021 13:39:28 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> We expect SADebugDTest.java will retly the test when it encounters "Address already in use" error. However RuntimeException is thrown when the error happens.
> 
> So I fixed it with some refactoring in this PR. Key change is the condition in L129.
> 
> Please see serviceability-dev post for details.
> https://mail.openjdk.java.net/pipermail/serviceability-dev/2021-December/040453.html

You'll need to update the copyright.

test/hotspot/jtreg/serviceability/sa/sadebugd/SADebugDTest.java line 75:

> 73: 
> 74:     private static boolean checkOutput(final String line, final int rmiPort) {
> 75:         boolean useRmiPort = rmiPort != -1;

I think rather than recomputing useRmiPort, which the caller already knows, you should instead just pass it in as an argument.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6941