[8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load

[Hohensee, Paul]

Hi, Serguei,

For 8u, we're still using mailing lists, not PRs. We'll move to PRs when 8u moves to github, which I believe is scheduled for real soon now (for 8u332). Hedong (I think I got his first name right!) just needs to tag the JBS issue with jdk8u-fix-request and add a Fix Request comment pointing to your review email (at https://mail.openjdk.java.net/pipermail/jdk8u-dev/). hg-updater will create a backport JBS issue after the commit.

Thanks,
Paul

-----Original Message-----
From: serviceability-dev <serviceability-dev-retn at openjdk.java.net> on behalf of Serguei Spitsyn <serguei.spitsyn at oracle.com>
Date: Tuesday, January 4, 2022 at 3:05 PM
To: hedongbo <hedongbo at huawei.com>, jdk8u-dev <jdk8u-dev at openjdk.java.net>
Cc: "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>
Subject: Re: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load

Hi Hedongbo,

The backport looks okay to me.
But I do not see where I can mark it as approved.
Do you have a PR (Pool Request) or a backport bug number?

Thanks,
Serguei


On 12/29/21, 7:58 PM, "jdk8u-dev on behalf of hedongbo" <jdk8u-dev-retn at openjdk.java.net on behalf of hedongbo at huawei.com> wrote:

    This problem has affected the customer's use at present. Can anyone help to take a look? Thanks.

    Thanks,
    hedongbo

    From: hedongbo
    Sent: Friday, December 17, 2021 9:35 AM
    To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
    Cc: 'serviceability-dev at openjdk.java.net' <serviceability-dev at openjdk.java.net>
    Subject: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load


    Hi,

    Please review the backport of JDK-8173361 to 8u.
    Bug: https://bugs.openjdk.java.net/browse/JDK-8173361
    11u commit: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/99bdef096320
    8u webrev: https://cr.openjdk.java.net/~dongbohe/8173361/webrev.00/

    This patch doesn't apply cleanly.
    I turned NoSafepointVerifier to No_Safepoint_Verifier because JDK- 8146690[1] changed the naming convention.
    I removed the mutexLocker.cpp changeset because JDK-8047290[2]  does not exist in 8.
    I added the CLDClosure* to ServiceThread::oops_do because JDK- 8154580[3] does not exist in 8.

    Tested with tier1. No regression in tests.
    Follow-up fix JDK-8235218[4] is planned to be backported as well.

    [1] https://bugs.openjdk.java.net/browse/JDK-8146690
    [2] https://bugs.openjdk.java.net/browse/JDK-8047290
    [3] https://bugs.openjdk.java.net/browse/JDK-8154580
    [4] https://bugs.openjdk.java.net/browse/JDK-8235218


    Thanks,

    hedongbo