RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT [v2]

Xin Liu xliu at openjdk.java.net
Wed Jan 19 06:57:29 UTC 2022


On Wed, 19 Jan 2022 06:49:54 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Intercept SIGQUIT in the early stage of HotSpot.
>
> src/hotspot/os/posix/signals_posix.cpp line 597:
> 
>> 595: #endif
>> 596: 
>> 597:   if (!signal_was_handled && sig == BREAK_SIGNAL) {
> 
> I would print out a little message, since callers of SIGQUIT may expect something to happen here. Maybe "Thread dumps not yet available"?
> Also, just for clarity, assert(!ReduceSignalHandling)? (but we don't do that for the other signals we omit handling either, so maybe not)

This is in the signal handler. Is it safe to print message or do something complex?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7003


More information about the serviceability-dev mailing list