RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

[Thomas Stuefe]

On Mon, 24 Jan 2022 04:22:34 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> BTW, I have some scripts for checking how often a header file is included. See https://github.com/iklam/tools/tree/main/headers
> 
> count_hotspot_headers.tcl shows that allocation.hpp was included by 1006 .o files before this fix, and 996 files afterwards, so not a whole lot of reduction. That's because we have over 300 headers that include allocatons.hpp :-)

Yes. allocation.hpp could be split up more. E.g. MEMFLAGS and the NMT categories really should live somewhere else, I saw some places where allocation.hpp was included only because of them. StackObj may also be a good candidate for moving to an own small header.

Does your tool tell you include chokepoints, maybe its just one central include pulling in allocation.hpp?

> Unfortunately I am seeing failures on macos and windows:
> 
> macos:
> 
> src/hotspot/os/bsd/gc/z/zNUMA_bsd.cpp:25: src/hotspot/share/gc/z/zNUMA.hpp:39:10: error: unknown type name 'uint32_t'
> 
> windows:
> 
> src\hotspot\os\windows\threadLocalStorage_windows.cpp(34): error C3861: 'assert': identifier not found

Strange, since the GHAs went through. What are your build flags? We should be able to rely on GHAs for builds at least :(

The bugs are easy to fix though. Thanks for testing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7188