RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v2]

Thomas Stuefe stuefe at openjdk.java.net
Mon Jan 24 07:41:45 UTC 2022


On Mon, 24 Jan 2022 05:44:50 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> JDK-8249944 moved AllStatic to its own header. We should use that one instead of allocation.hpp where possible to reduce header dependencies.
>> 
>> This patch:
>> - replaces includes of allocation.hpp with allstatic.hpp where appropiate
>> - fixes up resulting errors since this changes uncovers missing dependencies. Mainly, missing includes of debug.hpp, of globalDefinitions.hpp, and missing outputStream definitions.
>> 
>> Changes are trivial but onerous. Done partly with a script, partly manually.
>> 
>> Test:
>> - Checked the build with gtests on Linux x86, x64, minimal, zero, aarch64, for both fastdebug and release. All builds of course without PCH.
>> - GHAs
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add missing includes for macos, windows

Hi Ioi,

I fixed Windows, but cannot test MacOS since I don't have the hardware. Could you please give this another try?

Found out that the reason we don't see failing builds in GHAs is that GHAs build with precompiled headers. We should change this if possible.

Thanks, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/7188


More information about the serviceability-dev mailing list