RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases [v3]

Aleksey Shipilev shade at openjdk.java.net
Tue Jan 25 16:23:35 UTC 2022


On Tue, 18 Jan 2022 19:36:18 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Update copyright dates
>>  - Merge branch 'master' into JDK-8280166-getobjectsize
>>  - Merge branch 'master' into JDK-8280166-getobjectsize
>>  - Fix
>
> test/jdk/java/lang/instrument/GetObjectSizeIntrinsicsTest.java line 326:
> 
>> 324: 
>> 325:     public static void main(String[] args)throws Throwable {
>> 326:         new GetObjectSizeIntrinsicsTest(args[0], (args.length >= 2 ? args[1] : "")).runTest();
> 
> Shouldn't this be `args.length == 2`?

@plummercj This does not look like a review-blocking comment, so I am going to proceed with integration, if there are no other comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7132


More information about the serviceability-dev mailing list