RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v2]

[Chris Plummer]

On Mon, 24 Jan 2022 10:40:44 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Changes:
>> - ClassFileReconstituter is updated to restore "MethodParameters" attribute;
>> - handling of the attribute in VM_RedefineClasses is moved to be consistent with other code (like local variable table);
>> - copied ClassTransformer class (from test/jdk/com/sun/jdi/lib/jdb) to /test/lib as it's used by tests from hotspot and jdk (and also by test from Valhalla repo); Will file a follow up issues to updates tests and remove the class from test/jdk/com/sun/jdi/lib/jdb
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed condition

The changes look good except I haven't look at the new test that closely. It really could use a high level explanation of how the test works, plus some embedded comments. Too much to figure out by just looking at the code. Also, is there an existing test it was based on? Seems like a lot of code just for testing of a single attribute.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7180