RFR: 8280601: ClhsdbThreadContext.java test is triggering codecache related assert in PointerFinder.find()

[Kevin Walls]

On Tue, 25 Jan 2022 22:07:37 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> It's possible for an address to be in the codecache but not in any CodeBlob. Don't assert in this case.
> 
> Note I couldn't reproduce this failure. Not sure why since it seemed to reproduce pretty readily in our CI tier7, and I ran with the same options.

Marked as reviewed by kevinw (Committer).

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/PointerLocation.java line 305:

> 303:       } else {
> 304:         if (Assert.ASSERTS_ENABLED) {
> 305:           Assert.that(isInBlobUnknownLocation(), "Should have known location in CodeBlob");

Line 305's Assert message is hard to understand: "Should have known location in CodeBlob", when it would accept knowing that the location is unknown.

It means that none of the isInBlobXXX flags are true, and probably impossible to trigger at the moment.
If you ever wanted to delete it, or make it say "Should have known or unknown location in CodeBlob" then I'd agree. 8-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7217