RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v2]

Alex Menkov amenkov at openjdk.java.net
Wed Jan 26 16:42:34 UTC 2022


On Wed, 26 Jan 2022 07:23:00 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed condition
>
> test/jdk/java/lang/instrument/RetransformWithMethodParametersTest.java line 54:
> 
>> 52: import jdk.test.lib.util.ClassTransformer;
>> 53: 
>> 54: class MethodParametersTarget {
> 
> The test has a lack of comments, so it is not easy to read and understand it.
> Could you look at it and consider adding some comments where it makes sense to add?
> For instance, some explanation is needed on how `@1` with tags `commentout` and `uncomment` are used.
> It is not convenient to go deep into the `jdk.test.lib.util.ClassTransformer` to get such answers.
> At least some comment should suggest to look at this class to save time of analysis.

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7180


More information about the serviceability-dev mailing list