[jdk19] RFR: 8288703: GetThreadState returns 0 for virtual thread that has terminated

[Chris Plummer]

On Fri, 1 Jul 2022 17:47:51 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> This is fixing the JVM TI GetThreadState issue which returns for terminated virtual thread state = 0 instead of 2 (`JVMTI_THREAD_STATE_TERMINATED`). The problem was in the function `JvmtiEnvBase::get_threadOop_and_JavaThread` which does a check and reurns JVMTI_ERROR_THREAD_NOT_ALIVE a little bit early (before the values of `java_thread` and `thread_oop` are set). This was a root cause of the `GetThreadState` incorrect behavior.

Marked as reviewed by cjplummer (Reviewer).

test/hotspot/jtreg/serviceability/jvmti/vthread/SelfSuspendDisablerTest/SelfSuspendDisablerTest.java line 102:

> 100:         }
> 101: 
> 102:         testJvmtiThreadState(t2, SUSPENDED);

Not a useful check after the isSuspended(t2) call above, but no harm in it either.

-------------

PR: https://git.openjdk.org/jdk19/pull/102