RFR: 8282730: LdapLoginModule throw NPE from logout method after login failure [v2]
Sean Mullan
mullan at openjdk.org
Tue Jul 12 14:59:46 UTC 2022
On Mon, 11 Jul 2022 21:03:16 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> test/jdk/javax/security/auth/login/modules/SafeLogout.java line 51:
>>
>>> 49:
>>> 50: static void test(int pos) throws Exception {
>>> 51: // Create random JAAS login config.
>>
>> I'm probably missing something obvious, but can you explain why this test uses a random login config? I would add some comments explaining that more.
>
> I cannot find a way to test all combinations so I make it random. If it really fails I make sure the login module name, flag, and whether there is a login attempt are printed out so I can reproduce it.
Why isn't it sufficient to just call logout once per each login module?
-------------
PR: https://git.openjdk.org/jdk/pull/9348
More information about the serviceability-dev
mailing list