RFR: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

[Leonid Mesnik]

On Thu, 21 Jul 2022 23:01:55 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the output of non-generation (ZGC) GC as valid.
>
> test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48:
> 
>> 46:         S0(GcStatisticsType.PERCENTAGE_OR_DASH),
>> 47:         S1(GcStatisticsType.PERCENTAGE_OR_DASH),
>> 48:         E(GcStatisticsType.PERCENTAGE_OR_DASH),
> 
> I don't see jstat tests in the zgc problem list. Is this fixing known test failures?

Yes, ZGC reports dash for eden and survivor spaces.

> test/jdk/sun/tools/jstatd/JstatdTest.java line 131:
> 
>> 129:     private OutputAnalyzer runJps() throws Exception {
>> 130:         JDKToolLauncher launcher = JDKToolLauncher.createUsingTestJDK("jps");
>> 131:         launcher.addVMArgs(Utils.getFilteredTestJavaOpts("-XX:+UsePerfData"));
> 
> I assume this is removed because jps only requires that the target JVMs be run with UsePerfData, but not jps itself.

jps doesn't require all vm options which we use for test VM. 
The Utils.getFilteredTestJavaOpts("-XX:+UsePerfData") don't filter anything really, because it use regexp. So we just don't set GC for jps.

-------------

PR: https://git.openjdk.org/jdk/pull/9604