RFR: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName

Chris Plummer cjplummer at openjdk.org
Mon Jul 25 17:00:10 UTC 2022


On Sat, 23 Jul 2022 19:41:07 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Fixed tests that use eName to print event name to print the class name. Plus some minor refactoring.

Changes requested by cjplummer (Reviewer).

test/hotspot/jtreg/vmTestbase/nsk/jdi/Event/request/request001.java line 560:

> 558:                 if ((flagsCopy & flag) == 0) {
> 559:                     log3("ERROR: event duplication. flafsCopy = " + Integer.toBinaryString(flagsCopy)
> 560:                             + " flag = " + Integer.toBinaryString(flag));

typo: flafsCopy

I think you should print the event also.

test/hotspot/jtreg/vmTestbase/nsk/jdi/LocatableEvent/thread/thread001.java line 448:

> 446:                     throw new JDITestRuntimeException("** unexpected event **");
> 447:                 }
> 448:                 log2("--------> got: " + event1.getClass().getName() + " index: " + index);

Why not print the event rather than just its name.

-------------

PR: https://git.openjdk.org/jdk/pull/9624


More information about the serviceability-dev mailing list