RFR: 8290074: Remove implicit arguments for RegisterMap constructor [v2]

Axel Boldt-Christmas duke at openjdk.org
Wed Jul 27 09:45:25 UTC 2022


> Currently the `RegisterMap` constructor uses implicit boolean arguments to configure its function. Implicit boolean arguments makes code harder to understand and reason about at the call site. Using explicit scoped enums instead makes it both clear what is being configured and the type safety makes mistakes less likely. 
> 
> Update `RegisterMap` constructors to use these scoped enum types instead of booleans.
> ```C++
> enum class UpdateMap { skip, yes };
> enum class ProcessFrames { skip, yes };
> enum class WalkContinuation { skip, yes };
> 
> 
> Testing: tier1-3

Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:

  Rename yes to include

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9455/files
  - new: https://git.openjdk.org/jdk/pull/9455/files/2ba1c708..f597fcbb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9455&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9455&range=00-01

  Stats: 142 lines in 35 files changed: 0 ins; 0 del; 142 mod
  Patch: https://git.openjdk.org/jdk/pull/9455.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9455/head:pull/9455

PR: https://git.openjdk.org/jdk/pull/9455


More information about the serviceability-dev mailing list