RFR: 8288752: Split thread implementation files
David Holmes
dholmes at openjdk.org
Mon Jun 20 23:59:00 UTC 2022
On Mon, 20 Jun 2022 15:49:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> This changes splits thread.hpp/cpp into javaThread, and threads files.
>
> I left the commits intact to see better the progression of changes, but most files are include file changes. The only tricky parts are that some files were included in thread.hpp, like mutexLocker.cpp, which has to be included in the files that need it.
>
> I didn't update the copyrights to save diffs but will before integration.
> Also I won't integrate until after Dan's JDK 19 changes are merged into JDK 20.
>
> Tested with tier1-4 on Oracle supported platforms and built on other platforms.
Hi Coleen,
The changes in themselves seem fine to me - I only skimmed things, mainly looking at the new files. It is a very large refactoring so there will be an impact on backports naturally.
I'm not sure this will save much in terms of build time inclusions (how many files only include thread.hpp now?) but the code structure/management benefits of this are more important anyway. (Though I must confess in a remote terminal using vi I appreciate everything being in one file. :) ).
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9218
More information about the serviceability-dev
mailing list