RFR: 8287281: adjust guarantee in Handshake::execute for the case of target thread being current [v7]

Johan Sjölén duke at openjdk.org
Tue Jun 21 19:25:38 UTC 2022


On Tue, 21 Jun 2022 19:22:43 GMT, Johan Sjölén <duke at openjdk.org> wrote:

>> Please review this PR for fixing JDK-8287281.
>> 
>> If a thread is handshake safe we immediately execute the closure, instead of going through the regular Handshake process. 
>> 
>> Finally:  Should `VirtualThreadGetThreadClosure` and its `do_thread()` body be inlined instead? We can do this in this PR, imho, but I'm hoping to get some input on this.
>> 
>> 
>> Passes tier1. Running tier2-5.
>
> Johan Sjölén has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check only for target == current

The scope of the ticket is precisely for the case when `Thread::current() == target` and as such the fix only checks for this particular case now.

@dcubed-ojdk, does this change look good to you?

-------------

PR: https://git.openjdk.org/jdk/pull/8992


More information about the serviceability-dev mailing list