RFR: 8288752: Split thread implementation files [v5]

Coleen Phillimore coleenp at openjdk.org
Tue Jun 21 19:58:40 UTC 2022


On Tue, 21 Jun 2022 19:38:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This changes splits thread.hpp/cpp into javaThread, and threads files.
>> 
>> I left the commits intact to see better the progression of changes, but most files are include file changes.  The only tricky parts are that some files were included in thread.hpp, like mutexLocker.cpp, which has to be included in the files that need it.
>> 
>> I didn't update the copyrights to save diffs but will before integration.
>> Also I won't integrate until after Dan's JDK 19 changes are merged into JDK 20.
>> 
>> Tested with tier1-4 on Oracle supported platforms and built on other platforms.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More GHA fixes.

Thanks for reviewing, Ioi.  My intention was more modularity but it's disappointing that the build times don't improve since I culled several (too many, it seems) header files from thread.hpp. But as you said, this is a good step towards the goal of having less excess header file inclusions.

-------------

PR: https://git.openjdk.org/jdk/pull/9218


More information about the serviceability-dev mailing list