RFR: 8135292: Remove duplicate code in <OS>Address.java in SA

Jayashree Huttanagoudar duke at openjdk.org
Tue Jun 21 21:59:28 UTC 2022


On Fri, 10 Jun 2022 09:45:00 GMT, Jayashree Huttanagoudar <duke at openjdk.org> wrote:

>> This PR is to address : https://bugs.openjdk.org/browse/JDK-8135292?jql=labels%20%3D%20starter-bug
>> Verified the build before and after the patch. Also below tests are run:
>> Before Patch:
>> 
>> $ make test TEST="jtreg:test/hotspot/jtreg/serviceability"
>> 	==============================
>> 	Test summary
>> 	==============================
>> 	   TEST                                              TOTAL  PASS  FAIL ERROR   
>> 	>> jtreg:test/hotspot/jtreg/serviceability             316   314     1     1 <<
>> 	==============================
>> 	TEST FAILURE
>> 
>> 
>> After Patch:
>> 
>> $ make test TEST="jtreg:test/hotspot/jtreg/serviceability"
>> 	==============================
>> 	Test summary
>> 	==============================
>> 	   TEST                                              TOTAL  PASS  FAIL ERROR   
>> 	>> jtreg:test/hotspot/jtreg/serviceability             316   314     1     1 <<
>> 	==============================
>> 	TEST FAILURE
>
> Ok! Thank you!

> @jhuttana Try not to force push when contributing to OpenJDK, unless there isn't a better solution, doing so makes it harder to review the PR

Sure I will take care of that next time. 
As I am new to this process, now I have a confusion :) i.e, how to handle the scenarios where if something needs to be changed in the commit message or changes in any files that I realize  after pushing and raising a PR ?

-------------

PR: https://git.openjdk.org/jdk/pull/9112


More information about the serviceability-dev mailing list