RFR: 8135292: Remove duplicate code in <OS>Address.java in SA

Jayashree Huttanagoudar duke at openjdk.org
Tue Jun 21 21:59:29 UTC 2022


On Tue, 21 Jun 2022 08:42:29 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > how to handle the scenarios where if something needs to be changed in the commit message or changes in any files that I realize after pushing and raising a PR ?
> 
> You don't need to change the commit messages. Once reviewed, the commit message will be set by the bots. Just look at the git log of existing commits. All you can do to influence the message is using `/summary` or the likes. In a nutshell, don't do it. If you need to add extra changes, add them as separate commits on top of the previous one to your PR branch. That's it. The bot will rebase and merge commits when integrating.

Sure its clear to me now :) Thank you !

-------------

PR: https://git.openjdk.org/jdk/pull/9112


More information about the serviceability-dev mailing list