RFR: 8287281: adjust guarantee in Handshake::execute for the case of target thread being current [v7]

David Holmes dholmes at openjdk.org
Wed Jun 22 06:55:06 UTC 2022


On Tue, 21 Jun 2022 19:22:43 GMT, Johan Sjölén <duke at openjdk.org> wrote:

>> Please review this PR for fixing JDK-8287281.
>> 
>> If a thread is handshake safe we immediately execute the closure, instead of going through the regular Handshake process. 
>> 
>> Finally:  Should `VirtualThreadGetThreadClosure` and its `do_thread()` body be inlined instead? We can do this in this PR, imho, but I'm hoping to get some input on this.
>> 
>> 
>> Passes tier1. Running tier2-5.
>
> Johan Sjölén has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check only for target == current

I'm okay with this in current form.

I'll leave it to Dan to decide whether he thinks restoring the old TLH "invariant" should be done in a separate RFE.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/8992


More information about the serviceability-dev mailing list