RFR: 8135292: Remove duplicate code in <OS>Address.java in SA
Jayashree Huttanagoudar
duke at openjdk.org
Wed Jun 22 09:01:42 UTC 2022
On Tue, 21 Jun 2022 23:18:10 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
> There are also SA tests in `test/jdk/sun/tools/jhsdb` that should be run.
I will run those tests too once after making the changes you suggested.
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java line 528:
>
>> 526: public long getAddressValue(Address addr) {
>> 527: if (addr == null) return 0;
>> 528: return ((BsdAddress) addr).asLongValue();
>
> `asLongValue()` is declared in `Address`, so it should not be necessary to cast to a `BsdAddress` (and there are similar casts in the changes below that can be removed).
ok sure
-------------
PR: https://git.openjdk.org/jdk/pull/9112
More information about the serviceability-dev
mailing list