Integrated: 8289126: Cleanup unnecessary null comparison before instanceof check in jdk.hotspot.agent
Andrey Turbanov
aturbanov at openjdk.org
Mon Jun 27 07:32:57 UTC 2022
On Fri, 24 Jun 2022 09:19:33 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
> Update code checks both non-null and instance of a class in jdk.hotspot.agent module classes.
> The checks and explicit casts could also be replaced with pattern matching for the instanceof operator.
>
> For example, the following code:
>
> Object node = tree.getLastSelectedPathComponent();
> if (node != null && node instanceof SimpleTreeNode) {
> showInspector((SimpleTreeNode)node);
> }
>
> Can be simplified to:
>
> Object node = tree.getLastSelectedPathComponent();
> if (node instanceof SimpleTreeNode simpleNode) {
> showInspector(simpleNode);
> }
>
>
> See similar cleanup in java.base - [JDK-8258422](https://bugs.openjdk.java.net/browse/JDK-8258422)
This pull request has now been integrated.
Changeset: 7905788e
Author: Andrey Turbanov <aturbanov at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/7905788e969727c81eea4397f0d9b918cdb5286a
Stats: 62 lines in 18 files changed: 0 ins; 13 del; 49 mod
8289126: Cleanup unnecessary null comparison before instanceof check in jdk.hotspot.agent
Reviewed-by: ayang, cjplummer
-------------
PR: https://git.openjdk.org/jdk/pull/9272
More information about the serviceability-dev
mailing list