RFR: 8256811: Delayed/missed jdwp class unloading events [v3]
Zhengyu Gu
zgu at openjdk.org
Mon Jun 27 19:08:43 UTC 2022
On Sat, 25 Jun 2022 05:42:08 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiExport.cpp line 1722:
>>
>>> 1720: if (javaThread->is_in_VTMS_transition()) {
>>> 1721: return; // no events should be posted if thread is in a VTMS transition
>>> 1722: }
>>
>> Chris suggested to convert this if-statement to assert.
>> The concern is we want to be sure the debug agent does not skip any CLASS_UNLOAD events.
>> Though, I feel that a probability to get the assert triggered is very low.
>
>> Chris suggested to convert this if-statement to assert.
>> The concern is we want to be sure the debug agent does not skip any CLASS_UNLOAD events.
>> Though, I feel that a probability to get the assert triggered is very low.
>
> Yes, I think it should be an assert, but was not suggesting that change as part of this PR since it is pre-existing. We can file a separate CR for it.
Yes, I agree that it should be another CR.
-------------
PR: https://git.openjdk.org/jdk/pull/9168
More information about the serviceability-dev
mailing list