[jdk19] RFR: 8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and can_support_virtual_threads

Daniel D. Daugherty dcubed at openjdk.org
Wed Jun 29 16:04:39 UTC 2022


On Tue, 28 Jun 2022 09:02:59 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> This is spec only change to the JVM TI spec. The `SuspendAllVirtualThreads` and `ResumeAllVirtualThreads` functions added in Java 19 currently specify that they require one of the capabilities `can_suspend` or `can_support_virtual_threads`. This is not correct as both capabilities are required.
> 
> The issue is in the XSL used to generate the spec, and specifically the `capabilities` template where it emits different text when the number of required capabilities is not 0 or 1. Additionally, the description of the `can_support_virtual_threads` is overridden in both functions to avoid making it appear that the capability on its own is needed to use these functions.

Thumbs up.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/82


More information about the serviceability-dev mailing list