RFR: 8282475: SafeFetch should not rely on existence of Thread::current [v3]

Johannes Bechberger duke at openjdk.java.net
Tue Mar 8 09:10:02 UTC 2022


On Tue, 8 Mar 2022 08:59:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I'm open for suggestions, but putting it there was the simplest way. The problem is that os is not a namespace, but a class. But this could and should probably be changed.
>
> I was suggesting pushing everything in to os::ThreadWXEnable class.

I don't think that this would be good as this would lead to fairly long calls. I would rather create a class wx and place everything in this (renaming ThreadWXEnable to Enable).

>> We need this, because it does not compile (linker error) otherwise. But I forgot to include os.hpp (but included by thread.inline.hpp).
>
> But you didn't add anything that needs it - in fact you deleted `thread->enable_wx` - so perhaps the linker error was from a different variant of the fix?

You're right. That's weird.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7727


More information about the serviceability-dev mailing list